Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(share/eds): adding test utility for generating embedded test data #1320

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

distractedm1nd
Copy link
Collaborator

Self explanatory. Noticed this gap thanks to @walldiss

@codecov-commenter
Copy link

Codecov Report

Merging #1320 (5c9161f) into main (ed54f3e) will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
+ Coverage   54.87%   55.12%   +0.24%     
==========================================
  Files         176      176              
  Lines       10582    10575       -7     
==========================================
+ Hits         5807     5829      +22     
+ Misses       4200     4165      -35     
- Partials      575      581       +6     
Impacted Files Coverage Δ
nodebuilder/rpc/module.go 91.66% <0.00%> (-2.93%) ⬇️
share/ipld/get.go 91.20% <0.00%> (-1.39%) ⬇️
nodebuilder/rpc/rpc.go 100.00% <0.00%> (ø)
nodebuilder/das/daser.go 100.00% <0.00%> (ø)
nodebuilder/das/mocks/api.go 26.66% <0.00%> (ø)
nodebuilder/fraud/mocks/api.go 12.50% <0.00%> (ø)
nodebuilder/share/mocks/api.go 8.16% <0.00%> (ø)
nodebuilder/state/mocks/api.go 11.45% <0.00%> (ø)
nodebuilder/header/mocks/api.go 12.50% <0.00%> (ø)
nodebuilder/das/module.go 95.12% <0.00%> (+0.52%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG besides the question/suggestion

share/eds/eds_test.go Show resolved Hide resolved
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues is there so approve

Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the README doc !

@distractedm1nd distractedm1nd merged commit 3824c3b into celestiaorg:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:shares Shares and samples
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants