Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api/gateway): Implement context cancellation middleware #1321

Merged
merged 3 commits into from
Nov 9, 2022
Merged

feat(api/gateway): Implement context cancellation middleware #1321

merged 3 commits into from
Nov 9, 2022

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented Nov 3, 2022

Resolves #726

@renaynay renaynay added kind:improvement area:api Related to celestia-node API area:gateway Related to the node's gateway labels Nov 3, 2022
@renaynay renaynay self-assigned this Nov 3, 2022
Wondertan
Wondertan reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

api/gateway/middleware.go Outdated Show resolved Hide resolved
distractedm1nd
distractedm1nd previously approved these changes Nov 4, 2022
View reviewed changes
distractedm1nd
distractedm1nd previously approved these changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already reviewed, reapproving

@renaynay renaynay merged commit f79bda4 into celestiaorg:main Nov 9, 2022
@renaynay renaynay deleted the gateway-protect-context branch November 9, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

Assignees

@renaynay renaynay

Labels
area:api Related to celestia-node API area:gateway Related to the node's gateway
Projects
No open projects
Celestia Node
Status: Done
Milestone
No milestone
3 participants
@renaynay @distractedm1nd @Wondertan