Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nodebuilder): Use test node for tests instead of New #1350

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

renaynay
Copy link
Member

Fixes issue with this test not using in-memory keyring.

@renaynay renaynay added area:node Node kind:misc Attached to miscellaneous PRs labels Nov 11, 2022
@renaynay renaynay self-assigned this Nov 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1350 (d442b82) into main (90bd741) will decrease coverage by 0.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1350      +/-   ##
==========================================
- Coverage   55.33%   54.83%   -0.50%     
==========================================
  Files         178      178              
  Lines       10692    10692              
==========================================
- Hits         5916     5863      -53     
- Misses       4193     4250      +57     
+ Partials      583      579       -4     
Impacted Files Coverage Δ
nodebuilder/state/keyring.go 0.00% <0.00%> (-56.87%) ⬇️
libs/keystore/map_keystore.go 80.95% <0.00%> (-4.77%) ⬇️
share/eds/byzantine/bad_encoding.go 65.00% <0.00%> (-3.00%) ⬇️
share/eds/byzantine/pb/share.pb.go 32.88% <0.00%> (-1.97%) ⬇️
share/ipld/get.go 91.24% <0.00%> (-1.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good catch.

@renaynay renaynay merged commit a95b114 into celestiaorg:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:node Node kind:misc Attached to miscellaneous PRs
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants