Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eds/byzantine): trim NMTWrapper's namespace during BEFP validation #1354

Merged
merged 5 commits into from
Nov 15, 2022
Merged

fix(eds/byzantine): trim NMTWrapper's namespace during BEFP validation #1354

merged 5 commits into from
Nov 15, 2022

Conversation

evan-forbes
Copy link
Member

@evan-forbes evan-forbes commented Nov 11, 2022 •
edited by Wondertan
Loading

Overview

Fixes #1355
Adds a test for a false positive for BEFPs.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

This was referenced Nov 11, 2022
Closed
Merged
@evan-forbes evan-forbes added the bug Something isn't working label Nov 11, 2022
@evan-forbes evan-forbes self-assigned this Nov 11, 2022
@Wondertan Wondertan marked this pull request as ready for review November 15, 2022 13:45
@Wondertan Wondertan added area:shares Shares and samples kind:fix Attached to bug-fixing PRs and removed bug Something isn't working labels Nov 15, 2022
@Wondertan Wondertan changed the title chore: add test for false positive BEFP fix(eds/byznatine): trim NMTWrapper's namespace during BEFP validation Nov 15, 2022
@Wondertan Wondertan changed the title fix(eds/byznatine): trim NMTWrapper's namespace during BEFP validation fix(eds/byznatine): trim NMTWrappers namespace during BEFP validation Nov 15, 2022
distractedm1nd
distractedm1nd previously approved these changes Nov 15, 2022
View reviewed changes
@Wondertan Wondertan changed the title fix(eds/byznatine): trim NMTWrappers namespace during BEFP validation fix(eds/byzantine): trim NMTWrapper's namespace during BEFP validation Nov 15, 2022
walldiss
walldiss previously approved these changes Nov 15, 2022
View reviewed changes
@Wondertan Wondertan merged commit 290cc65 into celestiaorg:main Nov 15, 2022
@Wondertan Wondertan deleted the evan/test-false-positive-BEFP branch November 15, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay renaynay approved these changes

@Wondertan Wondertan Wondertan approved these changes

@distractedm1nd distractedm1nd distractedm1nd left review comments

@walldiss walldiss walldiss left review comments

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

Assignees

@evan-forbes evan-forbes

Labels
area:shares Shares and samples kind:fix Attached to bug-fixing PRs
Projects
No open projects
Celestia Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BEFP verification mechanism creates incorrect erasure encoded data
5 participants
@evan-forbes @walldiss @distractedm1nd @Wondertan @renaynay