Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(share): Implement ODSreader #1377

Merged
merged 11 commits into from
Nov 28, 2022
Merged

feat(share): Implement ODSreader #1377

merged 11 commits into from
Nov 28, 2022

Commits on Nov 28, 2022

  1. add ODSReader

    @walldiss
    walldiss committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4616d74 View commit details
    Browse the repository at this point in the history

  2. add test comments

    @walldiss
    walldiss committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    a119491 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
    @walldiss @renaynay
    walldiss and renaynay committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    35af555 View commit details
    Browse the repository at this point in the history

  4. Greatly reduce amount of buffer allocations 

    Apply review suggestions:
 - rescale Intn range
 - small renames & refactoring
    @walldiss
    walldiss committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    edc79af View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Ryan <ryanford@poluglottos.com>
    @walldiss @distractedm1nd
    walldiss and distractedm1nd committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    d081bb9 View commit details
    Browse the repository at this point in the history

  6. improve comments

    @walldiss
    walldiss committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    5043a4c View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Ryan <ryanford@poluglottos.com>
    @walldiss @distractedm1nd
    walldiss and distractedm1nd committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    95f15f4 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: rene <41963722+renaynay@users.noreply.github.com>
    @walldiss @renaynay
    walldiss and renaynay committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    830dfbf View commit details
    Browse the repository at this point in the history

  9. - rename bufferedODSReader 

     - add header length in error
    @walldiss
    walldiss committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    a83528d View commit details
    Browse the repository at this point in the history

  10. - update comments 

     - update ODSReader to use io.Reader
 - add reconstruction test
 - utilise provided container as much as possible before returning it
    @walldiss
    walldiss committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6abd657 View commit details
    Browse the repository at this point in the history

  11. fix comment

    @walldiss
    walldiss committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    95c3940 View commit details
    Browse the repository at this point in the history