Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allowing hostnames in gateway/rpc addr field #1378

Merged
merged 4 commits into from
Nov 21, 2022

Conversation

distractedm1nd
Copy link
Collaborator

@distractedm1nd distractedm1nd commented Nov 17, 2022

Overview

Closes #1374

IP/Hostname sanitization logic has been moved to utils. We now accept hostnames as valid addresses for the rpc and gateway, and the core ip parsing logic works the same way as the others now.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Merging #1378 (65dff96) into main (039facd) will increase coverage by 0.04%.
The diff coverage is 58.97%.

@@            Coverage Diff             @@
##             main    #1378      +/-   ##
==========================================
+ Coverage   55.21%   55.25%   +0.04%     
==========================================
  Files         178      179       +1     
  Lines       10744    10761      +17     
==========================================
+ Hits         5932     5946      +14     
- Misses       4232     4234       +2     
- Partials      580      581       +1     
Impacted Files Coverage Δ
nodebuilder/share/service.go 100.00% <ø> (ø)
share/eds/retriever.go 93.71% <ø> (ø)
nodebuilder/header/service.go 57.14% <25.00%> (ø)
libs/utils/address.go 59.09% <59.09%> (ø)
nodebuilder/gateway/config.go 68.42% <66.66%> (+5.92%) ⬆️
nodebuilder/rpc/config.go 66.66% <66.66%> (+6.66%) ⬆️
nodebuilder/core/config.go 57.14% <100.00%> (-5.36%) ⬇️
share/ipld/get.go 92.62% <0.00%> (+1.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Wondertan
Wondertan previously approved these changes Nov 17, 2022
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you extracted those in utils. Bad that we touched on unrelated comments. Can you remove those and extract into a separate PR, so that the squashed commit does not touch unrelated comments?

@distractedm1nd
Copy link
Collaborator Author

@Wondertan ya i can remove them. I already opened an issue that will fix the problem of make fmt fixing something the linter doesn't catch

renaynay
renaynay previously approved these changes Nov 17, 2022
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful thank u

Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Units failed, but unrelated to this PR, so approve

Copy link
Member

@MSevey MSevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, fine as follow ups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error is thrown when providing --gateway.addr flag
5 participants