-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allowing hostnames in gateway/rpc addr field #1378
fix: allowing hostnames in gateway/rpc addr field #1378
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1378 +/- ##
==========================================
+ Coverage 55.21% 55.25% +0.04%
==========================================
Files 178 179 +1
Lines 10744 10761 +17
==========================================
+ Hits 5932 5946 +14
- Misses 4232 4234 +2
- Partials 580 581 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great that you extracted those in utils. Bad that we touched on unrelated comments. Can you remove those and extract into a separate PR, so that the squashed commit does not touch unrelated comments?
@Wondertan ya i can remove them. I already opened an issue that will fix the problem of make fmt fixing something the linter doesn't catch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beautiful thank u
4212317
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Units failed, but unrelated to this PR, so approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, fine as follow ups.
Overview
Closes #1374
IP/Hostname sanitization logic has been moved to
utils
. We now accept hostnames as valid addresses for the rpc and gateway, and the core ip parsing logic works the same way as the others now.Checklist