Extract common parsing logic into single function. #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoytRen
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1394 +/- ##
==========================================
+ Coverage 56.02% 56.46% +0.44%
==========================================
Files 188 189 +1
Lines 11551 11477 -74
==========================================
+ Hits 6471 6481 +10
+ Misses 4443 4360 -83
+ Partials 637 636 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
The errors seem not on my side? |
renaynay
added
kind:misc
HoytRen
force-pushed
the
#1331
branch
2 times, most recently
from
c4b49ba
to
ccabc54
Compare
|
Thanks for your guide. The lint problem is gone. I will leave the problem cause by .gitignore file by now, and let other people fix it later. |
Wondertan
previously approved these changes
Dec 5, 2022
|
Sure, should I create another issue about the .gitignore first, or simply submit a PR? and I guess it's better to fix all detected problems once? |
|
Yeah, let's also make an issue with the problem statement. |
Revert .gitigonore file and leave the problem for now.
Wondertan
approved these changes
Dec 7, 2022
renaynay
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1331
When I compile cel-key, I see the binary is output to root, then I guess 'celestia' in the .igitigonre means the compiled binary, however it's moved to another place and not in root now.