Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): add extra arg to fix build #1410

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

evan-forbes
Copy link
Member

Overview

main isn't building due to a change in the api of a dependency and a recent PR. this PR adds an arbitrary number to fix that.

NOTE: I don't actually know what number we should put here. 3 seemed like a good number, so I used it.

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@evan-forbes evan-forbes added bug Something isn't working kind:fix Attached to bug-fixing PRs labels Nov 30, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1410 (2a1a56b) into main (8a6de42) will decrease coverage by 0.03%.
The diff coverage is 73.52%.

@@            Coverage Diff             @@
##             main    #1410      +/-   ##
==========================================
- Coverage   56.10%   56.07%   -0.04%     
==========================================
  Files         187      188       +1     
  Lines       11437    11551     +114     
==========================================
+ Hits         6417     6477      +60     
- Misses       4396     4439      +43     
- Partials      624      635      +11     
Impacted Files Coverage Δ
nodebuilder/header/constructors.go 75.00% <57.14%> (-4.17%) ⬇️
nodebuilder/header/config.go 51.78% <63.63%> (+3.13%) ⬆️
header/p2p/server.go 66.11% <69.23%> (-0.26%) ⬇️
header/p2p/options.go 70.49% <70.49%> (ø)
header/p2p/exchange.go 73.02% <81.25%> (-0.41%) ⬇️
header/p2p/session.go 76.99% <100.00%> (ø)
nodebuilder/config.go 87.80% <100.00%> (ø)
nodebuilder/header/module.go 94.04% <100.00%> (+1.08%) ⬆️
header/core/listener.go 52.83% <0.00%> (-5.67%) ⬇️
share/eds/byzantine/pb/share.pb.go 32.88% <0.00%> (-1.97%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@vgonkivs vgonkivs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, it's my fault 😢

header/p2p/exchange.go Outdated Show resolved Hide resolved
Co-authored-by: Viacheslav <viacheslavgonkivskyi@gmail.com>
@renaynay renaynay merged commit da4f54b into celestiaorg:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants