refactor(share/eds): Store methods take DataHash instead of share.Root
#1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
added
area:shares
renaynay
requested review from
Wondertan,
vgonkivs and
distractedm1nd
as code owners
distractedm1nd
suggested changes
Dec 6, 2022
Wondertan
reviewed
Dec 6, 2022
Wondertan
reviewed
Dec 6, 2022
distractedm1nd
previously approved these changes
Dec 6, 2022
Wondertan
reviewed
Dec 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #1439 +/- ##
==========================================
- Coverage 54.95% 54.89% -0.07%
==========================================
Files 196 196
Lines 11964 11971 +7
==========================================
- Hits 6575 6571 -4
- Misses 4737 4746 +9
- Partials 652 654 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wondertan
approved these changes
Dec 7, 2022
distractedm1nd
approved these changes
Dec 7, 2022
renaynay
added a commit
to renaynay/celestia-node
that referenced
this pull request
Dec 9, 2022
…Root` (celestiaorg#1439) Resolves celestiaorg#1428 Technically breaking API but it's not really used so it doesn't matter :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1428
Technically breaking API but it's not really used so it doesn't matter :)