Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/CI: Fix over kill of '.gitignore'. #1446

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

HoytRen
Copy link
Contributor

@HoytRen HoytRen commented Dec 7, 2022

Closes #1442

Limit some pattern to root folder.
Remove duplicated pattern.

@Wondertan
Copy link
Member

@HoytRen, don't fully understand the problem we are solving here. We had a similar PR before #566 btw. By mistake, we added . before paths and that didn't work, but it seems like it can work with just a slash. What's the diff between slash and no-slash in this case?

@HoytRen
Copy link
Contributor Author

HoytRen commented Dec 7, 2022

If there is a separator at the beginning or middle (or both) of the pattern, then the pattern is relative to the directory level of the particular .gitignore file itself. Otherwise the pattern may also match at any level below the .gitignore level.

@Wondertan
Copy link
Member

Ok. I see. Just for ref, the msg was copied from here.

.gitignore Show resolved Hide resolved
@Wondertan Wondertan added the kind:misc Attached to miscellaneous PRs label Dec 20, 2022
@Wondertan Wondertan merged commit 05c7527 into celestiaorg:main Dec 20, 2022
@HoytRen HoytRen deleted the #1442 branch December 21, 2022 07:02
@HoytRen
Copy link
Contributor Author

HoytRen commented Dec 21, 2022

Thank all of you. I'm caught by covid-19 these days, recovering, will get back soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:misc Attached to miscellaneous PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github/CI: Make .gitignore file more exact so that no new files get blocked.
3 participants