improvement(share/discovery): send peer to multiple readers #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
previously approved these changes
Dec 9, 2022
vgonkivs
force-pushed
the
improve_notifying_peers
branch
from
6e70b69
to
cb239c4
Compare
vgonkivs
force-pushed
the
improve_notifying_peers
branch
from
cb239c4
to
6e47669
Compare
distractedm1nd
approved these changes
Dec 9, 2022
walldiss
approved these changes
Dec 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #1460 +/- ##
==========================================
+ Coverage 55.45% 55.46% +0.01%
==========================================
Files 197 197
Lines 11999 12002 +3
==========================================
+ Hits 6654 6657 +3
Misses 4685 4685
Partials 660 660
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wondertan
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improvement for #1451
Notify multiple readers instead of one.
Checklist