Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(cel-key): Network alias check for --p2p.network flag #1482

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

renaynay
Copy link
Member

Allows users to pass the network alias instead of the full network name to the cel-key utility as is done with the celestia binary.

We allow networks other than the "valid" networks to be specified with the cel-key utility since it can be used for testing, but it will print a warning.

@renaynay renaynay added the kind:misc Attached to miscellaneous PRs label Dec 13, 2022
@renaynay renaynay self-assigned this Dec 13, 2022
Copy link
Member

@Wondertan Wondertan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long term the 🅱️ alidate should not return a network, but its fine for now

@renaynay renaynay merged commit ff95cf2 into celestiaorg:main Dec 21, 2022
@renaynay renaynay deleted the cel-key-update branch December 21, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:misc Attached to miscellaneous PRs
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants