fix(node/p2p)!: remove resource manager and it's API #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary fix for bootstrappers. Infinite Limits seem to be buggy. The proper fix is to update to the latest version of libp2p
Wondertan
added
kind:break!
|
@distractedm1nd, do we need to run openrpc-gen? It errors out for me Proof error |
Wondertan
force-pushed
the
hlib/p2p-rm-rsrmgr
branch
from
73377ca
to
9e44937
Compare
vgonkivs
previously approved these changes
Dec 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #1500 +/- ##
==========================================
+ Coverage 55.40% 55.47% +0.07%
==========================================
Files 203 203
Lines 12146 12125 -21
==========================================
- Hits 6729 6726 -3
+ Misses 4747 4731 -16
+ Partials 670 668 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
liamsi
changed the title
renaynay
approved these changes
Dec 19, 2022
|
@Wondertan No we don't need to run openrpc-gen, the error is coming from a missing example type and is unrelated |
distractedm1nd
suggested changes
Dec 19, 2022
distractedm1nd
approved these changes
Dec 19, 2022
Wondertan
added a commit
that referenced
this pull request
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for bootstrappers. Infinite Limits seem to be buggy. The proper fix is to update to the latest version of libp2p