refactor: exporting nodebuilder/header.InitStore, moving mock to nodebuilder/header #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…builder/header and supplying to TestNode
distractedm1nd
requested review from
renaynay,
Wondertan and
vgonkivs
as code owners
Wondertan
requested changes
Dec 21, 2022
renaynay
approved these changes
Dec 22, 2022
Wondertan
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Semi-old branch I forgot to open a PR for, that is related to #1458. Although we cannot fix the ugly error message without uber-go/fx#999, we can get rid of an ugly todo in a start hook.
This PR is purely a suggestion, and if the team doesn't like it we can just close it.
Checklist