refactor(nodebuilder/p2p): Add errors for all methods #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
added
area:p2p
kind:fix
renaynay
requested review from
adlerjohn,
liamsi,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
|
Seems to include auth commands |
Codecov Report
@@ Coverage Diff @@
## main #1539 +/- ##
==========================================
- Coverage 55.12% 55.04% -0.08%
==========================================
Files 211 211
Lines 12939 12953 +14
==========================================
- Hits 7132 7130 -2
- Misses 5080 5095 +15
- Partials 727 728 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
yes @Wondertan it's based on authcmd forgot to mention |
|
Should be in draft then |
…as p2p module is admin permissions level
Wondertan
approved these changes
Dec 23, 2022
distractedm1nd
approved these changes
Dec 23, 2022
liamsi
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1429
Adds an error as a return value for all methods as it is needed for elevated permission methods.