chore: bump celestia-app to v0.12.0-rc5 #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
evan-forbes
commented
Feb 1, 2023
Wondertan
force-pushed
the
evan/bump-celestia-app-v0.12.0-rc5
branch
from
c5bece3 to
581acd5
Compare
|
@evan-forbes, so this PR was also missing replacements for core and SDK |
|
whoops lol will go fix |
|
It's fixed |
|
But units are failing though |
|
Ok, it's a know flaky one, ready to go then |
|
I can go debug, it looks like |
|
|
sorry, github only showed me the first comment |
|
thanks for fixing! sorry about the silly mistakes |
renaynay
approved these changes
Feb 2, 2023
vgonkivs
approved these changes
Feb 2, 2023
distractedm1nd
approved these changes
Feb 2, 2023
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Feb 2, 2023
Co-authored-by: Wondertan <hlibwondertan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
bumps to v0.12.0-rc5
fwiw, I ran into a kinda funny issue since the imports in the proto files changed. We can't regenerate the proto files until we call
go mod tidy, but we can't callgo mod tidyuntil we regenerate the proto files. For posterity, the only way to fix this is to manually edit the proto files to a point where we can callgo mod tidy, then regenerate the protofiles.Checklist