Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(nodebuilder/tests): Clean up integration tests in p2p_test #2166

Merged
merged 2 commits into from
Sep 5, 2023
Merged

chore(nodebuilder/tests): Clean up integration tests in p2p_test #2166

merged 2 commits into from
Sep 5, 2023

Conversation

renaynay
Copy link
Member

@renaynay renaynay commented May 4, 2023

Cleans up swamp tests in p2p_test.go.

Based on #2162

@renaynay renaynay added swamp Related to Integration tests kind:chore labels May 4, 2023
@renaynay renaynay self-assigned this May 4, 2023
Wondertan
Wondertan reviewed May 8, 2023
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove unrelated tests from the diff?

EDIT: Ahhh, I submitted review for sync tests inside p2p tests

nodebuilder/tests/sync_test.go Outdated Show resolved Hide resolved
nodebuilder/tests/sync_test.go Outdated Show resolved Hide resolved
nodebuilder/tests/sync_test.go Outdated Show resolved Hide resolved
nodebuilder/tests/sync_test.go Outdated Show resolved Hide resolved
nodebuilder/tests/sync_test.go Outdated Show resolved Hide resolved
nodebuilder/tests/sync_test.go Outdated Show resolved Hide resolved
@renaynay renaynay requested a review from Wondertan May 10, 2023 08:32
distractedm1nd
distractedm1nd previously approved these changes Jun 13, 2023
View reviewed changes
walldiss
walldiss reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cleanup! Swamp looks so much better!

nodebuilder/tests/p2p_test.go Outdated Show resolved Hide resolved
nodebuilder/tests/p2p_test.go Show resolved Hide resolved
nodebuilder/tests/p2p_test.go Outdated Show resolved Hide resolved
nodebuilder/tests/p2p_test.go Outdated Show resolved Hide resolved
nodebuilder/tests/sync_test.go Outdated Show resolved Hide resolved
@Wondertan
Copy link
Member

@walldiss, @distractedm1nd, as this PR is based on #2162
let's review it first, unless I miss something @renaynay

@renaynay renaynay force-pushed the swamp-cleanussy-p2p branch 2 times, most recently from 8dc8258 to 6e4b893 Compare June 15, 2023 11:50
distractedm1nd
distractedm1nd previously approved these changes Sep 4, 2023
View reviewed changes
@renaynay renaynay mentioned this pull request Sep 4, 2023
Open
@renaynay renaynay merged commit f9cf180 into celestiaorg:main Sep 5, 2023
12 of 14 checks passed
@renaynay renaynay deleted the swamp-cleanussy-p2p branch September 5, 2023 08:22
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@walldiss walldiss walldiss approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@Wondertan Wondertan Awaiting requested review from Wondertan Wondertan is a code owner

Assignees

@renaynay renaynay

Labels
kind:chore swamp Related to Integration tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@renaynay @Wondertan @walldiss @distractedm1nd