Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(misc): pretty print namespace.iD and peer.ID #2255

Merged
merged 3 commits into from
May 29, 2023

Conversation

walldiss
Copy link
Member

Overview

Log namespace.ID and peer.ID in pretty format. Also opened an issue for nmt pkg to add StringHex method and if it is OK, will update PR to use it.

celestiaorg/nmt#200

@walldiss walldiss added kind:misc Attached to miscellaneous PRs kind:refactor Attached to refactoring PRs labels May 25, 2023
@walldiss walldiss self-assigned this May 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2255 (5dd9735) into main (7efdbbe) will increase coverage by 0.02%.
The diff coverage is 64.28%.

@@            Coverage Diff             @@
##             main    #2255      +/-   ##
==========================================
+ Coverage   50.46%   50.49%   +0.02%     
==========================================
  Files         150      150              
  Lines        9305     9304       -1     
==========================================
+ Hits         4696     4698       +2     
+ Misses       4212     4209       -3     
  Partials      397      397              
Impacted Files Coverage Δ
das/daser.go 64.83% <0.00%> (ø)
share/empty.go 57.69% <0.00%> (ø)
share/getter.go 0.00% <0.00%> (ø)
share/getters/cascade.go 76.71% <0.00%> (ø)
share/getters/tee.go 37.50% <0.00%> (ø)
share/p2p/peers/manager.go 73.85% <37.50%> (+0.06%) ⬆️
share/getters/ipld.go 67.05% <100.00%> (ø)
share/getters/shrex.go 65.85% <100.00%> (+0.42%) ⬆️
share/getters/store.go 82.27% <100.00%> (ø)
share/getters/utils.go 77.77% <100.00%> (ø)
... and 4 more

... and 1 file with indirect coverage changes

distractedm1nd
distractedm1nd previously approved these changes May 26, 2023
Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

renaynay
renaynay previously approved these changes May 29, 2023
share/getters/shrex.go Show resolved Hide resolved
share/p2p/peers/manager.go Show resolved Hide resolved
@walldiss walldiss enabled auto-merge (squash) May 29, 2023 12:40
@walldiss walldiss merged commit 6e0f3b9 into celestiaorg:main May 29, 2023
Wondertan pushed a commit that referenced this pull request May 30, 2023
## Overview

Log `namespace.ID` and `peer.ID` in pretty format.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:misc Attached to miscellaneous PRs kind:refactor Attached to refactoring PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants