feat(libs/pidstore): Implement PeerIDStore
#2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
vgonkivs,
distractedm1nd and
walldiss
as code owners
renaynay
force-pushed
the
persisted-peerstore
branch
from
7822805
to
54d5720
Compare
Co-authored-by: derrandz <ouaghad.hamza@gmail.com>
renaynay
force-pushed
the
persisted-peerstore
branch
from
54d5720
to
09ce736
Compare
Wondertan
reviewed
May 30, 2023
Co-authored-by: Hlib Kanunnikov <hlibwondertan@gmail.com>
Wondertan
approved these changes
May 30, 2023
walldiss
approved these changes
Jun 14, 2023
Codecov Report
@@ Coverage Diff @@
## main #2274 +/- ##
==========================================
+ Coverage 50.44% 50.68% +0.24%
==========================================
Files 155 156 +1
Lines 9826 9856 +30
==========================================
+ Hits 4957 4996 +39
+ Misses 4433 4421 -12
- Partials 436 439 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a
PeerIDStorethat will be useful for both dumping useful peers inside of celestia-node's use of p2p.Exchange as well as inside of discovery.Related to #1851