Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!(blob/module): fix api by changing variadic params to a slice #2293

Closed
wants to merge 3 commits into from

Conversation

vgonkivs
Copy link
Member

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added area:state Related to fetching state and state execution kind:break! Attached to breaking PRs kind:fix Attached to bug-fixing PRs area:blob labels May 31, 2023
@vgonkivs vgonkivs requested a review from renaynay as a code owner May 31, 2023 23:31
@vgonkivs vgonkivs self-assigned this May 31, 2023
distractedm1nd
distractedm1nd previously approved these changes Jun 1, 2023
Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next step is adding tests for our most critical rpc methods

walldiss
walldiss previously approved these changes Jun 1, 2023
Wondertan
Wondertan previously approved these changes Jun 1, 2023
renaynay
renaynay previously approved these changes Jun 1, 2023
@Wondertan
Copy link
Member

Let's double check we removed all the variadics in all modules

@codecov-commenter
Copy link

Codecov Report

Merging #2293 (94854d4) into main (1c1327b) will decrease coverage by 0.04%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main    #2293      +/-   ##
==========================================
- Coverage   50.80%   50.77%   -0.04%     
==========================================
  Files         154      154              
  Lines        9663     9663              
==========================================
- Hits         4909     4906       -3     
- Misses       4328     4331       +3     
  Partials      426      426              
Impacted Files Coverage Δ
api/gateway/state.go 0.00% <0.00%> (ø)
state/core_access.go 27.83% <ø> (ø)
blob/service.go 70.93% <33.33%> (ø)

... and 4 files with indirect coverage changes

Copy link
Collaborator

@distractedm1nd distractedm1nd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Another great test to add would be the full blob module lifecycle over RPC (trying to use all the methods)

@vgonkivs vgonkivs enabled auto-merge (squash) June 1, 2023 13:19
@vgonkivs vgonkivs disabled auto-merge June 1, 2023 13:23
@Wondertan Wondertan enabled auto-merge (squash) June 1, 2023 13:48
@vgonkivs vgonkivs disabled auto-merge June 1, 2023 15:14
@vgonkivs vgonkivs marked this pull request as draft June 1, 2023 15:14
@vgonkivs
Copy link
Member Author

vgonkivs commented Jun 1, 2023

closing in favour of #2298

@vgonkivs vgonkivs closed this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:blob area:state Related to fetching state and state execution kind:break! Attached to breaking PRs kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants