-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!(blob/module): fix api by changing variadic params to a slice #2293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next step is adding tests for our most critical rpc methods
Let's double check we removed all the variadics in all modules |
74a7dc8
Codecov Report
@@ Coverage Diff @@
## main #2293 +/- ##
==========================================
- Coverage 50.80% 50.77% -0.04%
==========================================
Files 154 154
Lines 9663 9663
==========================================
- Hits 4909 4906 -3
- Misses 4328 4331 +3
Partials 426 426
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Another great test to add would be the full blob module lifecycle over RPC (trying to use all the methods)
closing in favour of #2298 |
Overview
Checklist