Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gateway): remove the GetByHeight hussle and rely on Module's logic #2302

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

Wondertan
Copy link
Member

No description provided.

@Wondertan Wondertan added the kind:fix Attached to bug-fixing PRs label Jun 2, 2023
@Wondertan Wondertan requested a review from renaynay as a code owner June 2, 2023 09:24
@Wondertan Wondertan self-assigned this Jun 2, 2023
@Wondertan Wondertan changed the title fix(gateway): allow requesting headers higher than current head fix(gateway): remove the GetByHeight hussle and rely on Module's logic Jun 2, 2023
@mergify
Copy link

mergify bot commented Jun 2, 2023

⚠️ The sha of the head commit of this PR conflicts with #2297. Mergify cannot evaluate rules on this PR. ⚠️

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #2302 (f0f7d44) into main (218ab99) will increase coverage by 0.20%.
The diff coverage is 7.14%.

@@            Coverage Diff             @@
##             main    #2302      +/-   ##
==========================================
+ Coverage   50.82%   51.02%   +0.20%     
==========================================
  Files         154      154              
  Lines        9671     9633      -38     
==========================================
  Hits         4915     4915              
+ Misses       4329     4292      -37     
+ Partials      427      426       -1     
Impacted Files Coverage Δ
api/gateway/availability.go 0.00% <ø> (ø)
api/gateway/header.go 0.00% <ø> (ø)
api/gateway/share.go 7.69% <0.00%> (+1.02%) ⬆️
api/gateway/state.go 0.00% <0.00%> (ø)
state/core_access.go 27.83% <ø> (ø)
blob/service.go 70.93% <33.33%> (ø)

... and 2 files with indirect coverage changes

vgonkivs
vgonkivs previously approved these changes Jun 2, 2023
@Wondertan Wondertan force-pushed the hlib/gateway-get-header-attempt-2 branch from ae4311f to 24c5fa6 Compare June 2, 2023 09:37
@Wondertan Wondertan added the area:gateway Related to the node's gateway label Jun 2, 2023
@Wondertan Wondertan enabled auto-merge (squash) June 2, 2023 10:03
@Wondertan Wondertan merged commit af8460a into main Jun 2, 2023
@Wondertan Wondertan deleted the hlib/gateway-get-header-attempt-2 branch June 2, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:gateway Related to the node's gateway kind:fix Attached to bug-fixing PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants