Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(getter/cascade): cascade getter should return fast on context cancel #2310

Merged
merged 5 commits into from
Jun 2, 2023
Merged

fix(getter/cascade): cascade getter should return fast on context cancel #2310

merged 5 commits into from
Jun 2, 2023

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Jun 2, 2023 •
edited
Loading

Overview

Also fixes incorrect errors.Is for share.ErrNamespaceNotFound

Resolves #2174

@walldiss walldiss added area:shares Shares and samples kind:fix Attached to bug-fixing PRs labels Jun 2, 2023
@walldiss walldiss self-assigned this Jun 2, 2023
@walldiss walldiss force-pushed the fix_cascade_getter_context_canceled branch from dec5418 to 409a38f Compare June 2, 2023 18:14
Wondertan
Wondertan reviewed Jun 2, 2023
View reviewed changes
share/getters/cascade.go Outdated Show resolved Hide resolved
renaynay
renaynay previously approved these changes Jun 2, 2023
View reviewed changes
Wondertan
Wondertan reviewed Jun 2, 2023
View reviewed changes
share/getters/cascade.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023 •
edited
Loading

Codecov Report

Merging #2310 (697295c) into main (1247225) will increase coverage by 0.05%.
The diff coverage is 75.00%.

❗ Current head 697295c differs from pull request most recent head 04760db. Consider uploading reports for the commit 04760db to get more accurate results

@@            Coverage Diff             @@
##             main    #2310      +/-   ##
==========================================
+ Coverage   50.56%   50.61%   +0.05%     
==========================================
  Files         154      154              
  Lines        9729     9729              
==========================================
+ Hits         4919     4924       +5     
+ Misses       4384     4380       -4     
+ Partials      426      425       -1
Impacted Files Coverage Δ
share/getters/cascade.go 78.08% <75.00%> (+1.36%) ⬆️

... and 4 files with indirect coverage changes

@walldiss walldiss force-pushed the fix_cascade_getter_context_canceled branch from e7b59c3 to 697295c Compare June 2, 2023 18:42
Wondertan
Wondertan previously approved these changes Jun 2, 2023
View reviewed changes
renaynay
renaynay previously approved these changes Jun 2, 2023
View reviewed changes
@renaynay renaynay enabled auto-merge (squash) June 2, 2023 18:53
@walldiss walldiss dismissed stale reviews from renaynay and Wondertan via 98c6209 June 2, 2023 19:04
@renaynay renaynay merged commit 504ff93 into celestiaorg:main Jun 2, 2023
Wondertan pushed a commit that referenced this pull request Jun 6, 2023
@walldiss @Wondertan
fix(getter/cascade): cascade getter should return fast on context can…
fefbf1a 
…cel (#2310)

## Overview

Also fixes incorrect errors.Is for `share.ErrNamespaceNotFound`

Resolves #2174
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay renaynay approved these changes

@Wondertan Wondertan Wondertan approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd

Assignees

@walldiss walldiss

Labels
area:shares Shares and samples kind:fix Attached to bug-fixing PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getLeavesWithProofsByNamespace:could not retrieve node
4 participants
@walldiss @codecov-commenter @Wondertan @renaynay