-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parseNamespace for <= 10 byte namespace IDs #2325
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2325 +/- ##
==========================================
+ Coverage 50.55% 50.68% +0.12%
==========================================
Files 154 154
Lines 9733 9736 +3
==========================================
+ Hits 4921 4935 +14
+ Misses 4385 4373 -12
- Partials 427 428 +1
|
@rootulp, note that I am waiting for @distractedm1nd to return from sick leave and look deeper into this PR, as he is an author. I am not deep in the context of rpc cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sent @rootulp a fix for the missing test case and added two additional ones, now the coverage is pretty good. Once applied i will approve
Synced w/ @distractedm1nd offline and I'll push a few commits to this PR that renames things like namespace to namespace ID where applicable but we should really do #2301 ASAP. |
The scope of this PR has increased b/c it wasn't clear to me what the original intended behavior was. Would appreciate extra attention when reviewing b/c this couples a fix, refactor, and behavior change (left pad instead of right pad) |
@distractedm1nd, why do we want to disable versioning here? |
bdac967
to
ce262d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't get whats the point of panicking on user input though
4a098ab
to
30dda2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @rootulp
Closes #2321