fix!(state): use node blob type instead of app type to fix inconsistent unmarshalling #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
added
kind:break!
distractedm1nd
requested review from
Wondertan,
vgonkivs and
walldiss
as code owners
|
Going to rework this PR after a good suggestion from @vgonkivs to just have blob service take an interface for submitting data instead of moving blob/service to nodebuilder |
|
It will help to break dependency blob -> state |
distractedm1nd
force-pushed
the
pfb-submit-parity
branch
from
a382624
to
bc97346
Compare
vgonkivs
reviewed
Jun 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #2338 +/- ##
==========================================
- Coverage 50.89% 50.86% -0.04%
==========================================
Files 154 154
Lines 9746 9742 -4
==========================================
- Hits 4960 4955 -5
+ Misses 4352 4350 -2
- Partials 434 437 +3
|
vgonkivs
previously approved these changes
Jun 8, 2023
distractedm1nd
force-pushed
the
pfb-submit-parity
branch
from
1e4f76d
to
e7be89e
Compare
Wondertan
previously approved these changes
Jun 8, 2023
Wondertan
reviewed
Jun 8, 2023
walldiss
previously approved these changes
Jun 8, 2023
distractedm1nd
force-pushed
the
pfb-submit-parity
branch
from
75bae3f
to
2a3a8d9
Compare
walldiss
approved these changes
Jun 8, 2023
Wondertan
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks API to v0.2.0
Because state.SubmitPayForBlob was using apptypes.Blob, which cannot be unmarshalled from a node blob.Blob JSON object, it was requiring two separate types downstream. Now both blob Service and state Service use blob.Blob type.
The caveat here is that I had to move the blob service implementation inside nodebuilder, as we do for header service as well - due to import cycles. This is not a long term solution, as eventually we will share the blob type with appThis means introducing an interface in blob.Service called blob.Submitter to avoid that state module import.