feat!(nodbuilder): making lifecycle timeouts configurable #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
added
area:config
distractedm1nd
requested review from
Wondertan,
vgonkivs and
walldiss
as code owners
Wondertan
previously approved these changes
Jun 8, 2023
walldiss
previously approved these changes
Jun 13, 2023
renaynay
reviewed
Jun 14, 2023
Codecov Report
@@ Coverage Diff @@
## main #2347 +/- ##
==========================================
- Coverage 50.86% 50.69% -0.18%
==========================================
Files 154 155 +1
Lines 9742 9755 +13
==========================================
- Hits 4955 4945 -10
- Misses 4353 4373 +20
- Partials 434 437 +3
|
walldiss
approved these changes
Jun 14, 2023
renaynay
approved these changes
Jun 14, 2023
Wondertan
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2315
Doing this proactively even though it is a good-first issue in case other dagstore startup issues are not fixed in time. Breaks the config.