fix(rpc/client): stop overwriting existing clients #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
added
kind:fix
distractedm1nd
requested review from
renaynay,
Wondertan,
vgonkivs and
walldiss
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2361 +/- ##
==========================================
+ Coverage 50.84% 50.88% +0.04%
==========================================
Files 154 154
Lines 9746 9746
==========================================
+ Hits 4955 4959 +4
+ Misses 4355 4351 -4
Partials 436 436 |
Wondertan
approved these changes
Jun 13, 2023
renaynay
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2356 I uncovered a bug:
When using the
client.NewClientconstructor, it uses a global static struct to set the modules. This led to clients overwriting each other when multiple are initialized.