share: introduce Namespace type #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
renaynay,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2367 +/- ##
==========================================
- Coverage 50.81% 50.58% -0.23%
==========================================
Files 156 157 +1
Lines 9860 9927 +67
==========================================
+ Hits 5010 5022 +12
- Misses 4410 4463 +53
- Partials 440 442 +2
|
Wondertan
force-pushed
the
hlib/share/namespace-type
branch
from
81701f2
to
83977c4
Compare
walldiss
reviewed
Jun 15, 2023
renaynay
reviewed
Jun 15, 2023
rootulp
approved these changes
Jun 15, 2023
Wondertan
force-pushed
the
hlib/share/namespace-type
branch
from
83977c4
to
115161b
Compare
3 tasks
renaynay
reviewed
Jun 16, 2023
rootulp
approved these changes
Jun 16, 2023
distractedm1nd
approved these changes
Jun 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
5 tasks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 27, 2023
## Notable Changes - `namespace.ID` to `share.Namespace` - Changes every comment namespace ID mentioning to just namespace. I renamed every such mention besides in ADRs. I don't want to touch ADRs here, as they need a more holistic re-review and up-to-date catchup. - Uses all the utility methods on the type, where suitable - Namespace constructor now only creates Blob Namespaces. For other reserved namespaces, the predefined globals should be used. - Uses namespace.ValidateDataNamespace everywhere data is requested. This is guarantees we verify the namespace are 100% valid and forbids requesting parity and padding namespaces. - Restricts PFBs for reserved namespaces - Reversed the dependency from `share -> share/ipld` to `share/ipld -> share` - NewBlobV0 constructor. Similar to NewNamespaceV0 - `sharetest` pkg for share related testing utilities - `edstest` pkg for eds related testing utilities ## Follow-ups - `blobtest` pkg to generate node's blob type ## Refs * Substitutes zombie PR #2376. I push to the branch, but GH does not see commits. * Based on #2367 * Closes #2301 * Closes #2309 * Blocked on #2256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly copied from the app's Namespace type with multiple modifications. In preparation for #2301.
We want a more straightforward Namespace type from what the app provides: