chore(share/getters): add unit test for ctxwithsplittimeout #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
Wondertan,
vgonkivs and
distractedm1nd
as code owners
distractedm1nd
previously approved these changes
Jun 16, 2023
Codecov Report
@@ Coverage Diff @@
## main #2374 +/- ##
==========================================
- Coverage 50.72% 50.70% -0.03%
==========================================
Files 155 155
Lines 9830 9830
==========================================
- Hits 4986 4984 -2
- Misses 4407 4410 +3
+ Partials 437 436 -1 |
distractedm1nd
previously approved these changes
Jun 16, 2023
Wondertan
previously approved these changes
Jun 16, 2023
renaynay
previously approved these changes
Jun 16, 2023
walldiss
dismissed stale reviews from renaynay, Wondertan, and distractedm1nd
via
0475a38
Wondertan
approved these changes
Jun 16, 2023
vgonkivs
approved these changes
Jun 21, 2023
renaynay
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds extra safety.