!feat(share/p2p/shrex-nd): rework shrex-nd to serve data in multiple messages #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
changed the title
walldiss
force-pushed
the
shrexnd_multiple_messages
branch
from
c5d3a36
to
1de84ac
Compare
Codecov Report
@@ Coverage Diff @@
## main #2444 +/- ##
==========================================
- Coverage 53.12% 53.08% -0.04%
==========================================
Files 156 156
Lines 9907 9916 +9
==========================================
+ Hits 5263 5264 +1
- Misses 4188 4193 +5
- Partials 456 459 +3
|
Wondertan
reviewed
Jul 10, 2023
walldiss
force-pushed
the
shrexnd_multiple_messages
branch
2 times, most recently
from
1f54ab8
to
2154cc5
Compare
renaynay
reviewed
Jul 19, 2023
share/p2p/shrexnd/client.go
Outdated
| } | ||
|
|
||
| return c.convertResponse(ctx, resp) | ||
| return c.convertStatusToErr(ctx, resp.Status) | ||
| } | ||
|
|
||
| // convertToNamespacedShares converts proto Rows to share.NamespacedShares |
5 tasks
renaynay
reviewed
Jul 31, 2023
Wondertan
previously approved these changes
Aug 2, 2023
Wondertan
previously approved these changes
Aug 2, 2023
walldiss
force-pushed
the
shrexnd_multiple_messages
branch
from
e2e3bfc
to
2209c34
Compare
Wondertan
previously approved these changes
Aug 2, 2023
walldiss
force-pushed
the
shrexnd_multiple_messages
branch
from
bca4979
to
d60356e
Compare
Wondertan
previously approved these changes
Aug 4, 2023
walldiss
dismissed
Wondertan’s stale review
The merge-base changed after approval.
walldiss
force-pushed
the
shrexnd_multiple_messages
branch
from
d60356e
to
0608cb2
Compare
walldiss
force-pushed
the
shrexnd_multiple_messages
branch
from
c8fd9e9
to
054f5c7
Compare
walldiss
force-pushed
the
shrexnd_multiple_messages
branch
from
5929be2
to
ee96f10
Compare
walldiss
force-pushed
the
shrexnd_multiple_messages
branch
from
ee96f10
to
732704e
Compare
Wondertan
approved these changes
Aug 4, 2023
renaynay
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
shrex-nd protocol is limited to send messages with max size of 1mb. PR modifies shrex-nd protocol to stream namespace data row by row. Next time we will have msg size problem after ods size > 2048.
Resolves #2419