Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move versioning outside the main package #2468

Merged
merged 5 commits into from
Jul 14, 2023

Conversation

vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Jul 12, 2023

Overview

Move version flags outside the main package in order to have an access to them

./build/celestia version
Semantic version: v0.11.0-rc1-73-g509b74b9
Commit: 509b74b90bc6b3bf86f4730943abd3840430b03a
Build Date: Wed Jul 12 20:45:36 EEST 2023
System version: amd64/darwin
Golang version: go1.20.3

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@vgonkivs vgonkivs added the kind:misc Attached to miscellaneous PRs label Jul 12, 2023
@vgonkivs vgonkivs requested a review from renaynay as a code owner July 12, 2023 17:44
@vgonkivs vgonkivs self-assigned this Jul 12, 2023
@vgonkivs vgonkivs requested review from Bidon15 and tty47 July 12, 2023 18:07
nodebuilder/node_test.go Outdated Show resolved Hide resolved
@vgonkivs vgonkivs requested a review from Wondertan July 13, 2023 09:43
Wondertan
Wondertan previously approved these changes Jul 13, 2023
walldiss
walldiss previously approved these changes Jul 14, 2023
@vgonkivs vgonkivs dismissed stale reviews from walldiss and Wondertan via 2f3e12a July 14, 2023 06:00
@codecov-commenter
Copy link

Codecov Report

Merging #2468 (2f3e12a) into main (11dced4) will decrease coverage by 0.05%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main    #2468      +/-   ##
==========================================
- Coverage   52.88%   52.83%   -0.05%     
==========================================
  Files         156      156              
  Lines        9971     9966       -5     
==========================================
- Hits         5273     5266       -7     
- Misses       4236     4237       +1     
- Partials      462      463       +1     
Impacted Files Coverage Δ
cmd/celestia/util.go 56.52% <ø> (-5.02%) ⬇️
cmd/celestia/version.go 0.00% <0.00%> (ø)
nodebuilder/settings.go 64.28% <100.00%> (ø)

... and 7 files with indirect coverage changes

@Wondertan Wondertan merged commit 05e00e8 into celestiaorg:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:misc Attached to miscellaneous PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants