feat(share/eds): introduce List method for the Store #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
vgonkivs,
distractedm1nd and
walldiss
as code owners
|
Why do you respond like Javed? 😂 |
distractedm1nd
approved these changes
Aug 2, 2023
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Aug 4, 2023
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed fro and extracted from #2482
I honestly have a concern about DagStore scalability. It loads all the shard's info on the map, which long term will have to store all the edses we ever stored, which will be a looot.