fix(share/eds): print error for stuck register shard #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2516 +/- ##
==========================================
- Coverage 52.60% 52.33% -0.28%
==========================================
Files 156 156
Lines 9995 10013 +18
==========================================
- Hits 5258 5240 -18
- Misses 4272 4305 +33
- Partials 465 468 +3
|
Wondertan
reviewed
Jul 28, 2023
|
Latest tests shown not hangups. But still, we don't want to lose event of hangup and info all related info of if it happens. |
|
Agreed, yet sounds like it better be a metric |
renaynay
reviewed
Jul 31, 2023
There was a problem hiding this comment.
I agree with @Wondertan , this is better recorded as a metric.
|
Metric would need logic implemented in this PR. There are 3 cases for hangups, so I would rather have specified log lines. Also metrics are optional, but it will be important to be able to find those errors from logs in case this problem happens again |
Wondertan
approved these changes
Jul 31, 2023
distractedm1nd
approved these changes
Aug 2, 2023
|
Async Put would just kick the can down the road. |
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Aug 4, 2023
Sometimes register shard can take longer, that provided context timeout. This PR logs errors if register shard is stuck.
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Aug 4, 2023
Sometimes register shard can take longer, that provided context timeout. This PR logs errors if register shard is stuck.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes register shard can take longer, that provided context timeout. This PR logs errors if register shard is stuck.