Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump app v1.0.0 rc11 #2527

Merged
merged 13 commits into from
Aug 2, 2023
Merged

chore: bump app v1.0.0 rc11 #2527

merged 13 commits into from
Aug 2, 2023

Conversation

evan-forbes
Copy link
Member

Overview

This PR updates node to rc11 (unreleased atm) of app, which includes the changes needed to commit to invalid blocks. We can then test for BEFPs.

shoutout to @Wondertan and @renaynay for helping me debug!!!!

leaving as a draft until we have the official release of rc11, but we can start the review process

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@evan-forbes evan-forbes added the kind:deps Pull requests that update a dependency file label Jul 31, 2023
@evan-forbes evan-forbes self-assigned this Jul 31, 2023
@github-actions github-actions bot added the external Issues created by non node team members label Jul 31, 2023
evan-forbes
evan-forbes commented Jul 31, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
core/fetcher_test.go Show resolved Hide resolved
core/testing.go Show resolved Hide resolved
core/testing.go Show resolved Hide resolved
nodebuilder/tests/blob_test.go Show resolved Hide resolved
@evan-forbes evan-forbes removed the external Issues created by non node team members label Jul 31, 2023
@evan-forbes evan-forbes marked this pull request as ready for review August 2, 2023 10:55
@Wondertan Wondertan mentioned this pull request Aug 2, 2023
Merged
5 tasks
walldiss
walldiss approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@walldiss walldiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wondertan Wondertan merged commit fb8702d into main Aug 2, 2023
15 of 17 checks passed
@Wondertan Wondertan deleted the evan/bump-app-v1.0.0-rc11 branch August 2, 2023 17:16
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request Aug 4, 2023
@evan-forbes @walldiss
chore: bump app v1.0.0 rc11 (celestiaorg#2527)
88203d0
walldiss pushed a commit to walldiss/celestia-node that referenced this pull request Aug 4, 2023
@evan-forbes @walldiss
chore: bump app v1.0.0 rc11 (celestiaorg#2527)
32089cb
@evan-forbes evan-forbes mentioned this pull request Aug 7, 2023
Closed
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@walldiss walldiss walldiss approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd

Assignees

@evan-forbes evan-forbes

Labels
kind:deps Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evan-forbes @walldiss @Wondertan