misc(metrics)!: split global attributes into two #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
walldiss
force-pushed
the
split-metrics-attributes
branch
from
5e993bf
to
a4757d1
Compare
walldiss
force-pushed
the
split-metrics-attributes
branch
from
a4757d1
to
07cfb32
Compare
renaynay
approved these changes
Aug 8, 2023
walldiss
changed the title
vgonkivs
approved these changes
Aug 8, 2023
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Aug 23, 2023
## Overview Currently there is only one global attribute, that build by concatenating both exported attributes: ``` "job" = "Bridge/robusta-11rc9/12D3KooWAEQUSJh7aJFq7Cw1mP4VWnqfHtHwwwnsXHFhpQ2DMn7j" ``` `Breaking`, because this PR is breaking metrics compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently there is only one global attribute, that build by concatenating both exported attributes:
Breaking, because this PR is breaking metrics compatibility.