-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cmd): fix formatting during submit #2551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd and
walldiss
as code owners
August 9, 2023 20:29
jcstein
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worked for me as expected
celestia rpc blob submit 0x42690c204d39600fddd3 'gm'
{
"result": {
"uint64": 232874,
"commitment": "IXg+08HV5RsPF3Lle8PH+B2TUGsGUsBiseflxh6wB5E="
}
}
Codecov Report
@@ Coverage Diff @@
## main #2551 +/- ##
==========================================
+ Coverage 51.08% 51.10% +0.01%
==========================================
Files 158 158
Lines 10403 10401 -2
==========================================
+ Hits 5314 5315 +1
+ Misses 4626 4620 -6
- Partials 463 466 +3
|
distractedm1nd
approved these changes
Aug 10, 2023
renaynay
approved these changes
Aug 10, 2023
walldiss
approved these changes
Aug 10, 2023
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Aug 23, 2023
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
(cherry picked from commit 426c337)
walldiss
pushed a commit
that referenced
this pull request
Sep 22, 2023
(cherry picked from commit 426c337)
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
(cherry picked from commit 426c337)
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 25, 2023
(cherry picked from commit 426c337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As we expect direct types every time, I would suggest skipping error handling in case of format data(and simply return data if casting fails). I think this is the best way to keep logic generic and avoid any additional bool flags, options etc.
Checklist