fix(share/eds): don't use in-memory buffer for mount after shard recover #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
walldiss
changed the title
vgonkivs
approved these changes
Aug 10, 2023
renaynay
approved these changes
Aug 10, 2023
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Aug 23, 2023
…ver (celestiaorg#2554) When shard recovered in dagstore, it was read from in-memory mount, that could have been read 0 times and had no in-memory buffer.
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
…ver (celestiaorg#2554) When shard recovered in dagstore, it was read from in-memory mount, that could have been read 0 times and had no in-memory buffer. (cherry picked from commit 32834eb)
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
…ver (celestiaorg#2554) When shard recovered in dagstore, it was read from in-memory mount, that could have been read 0 times and had no in-memory buffer. (cherry picked from commit 32834eb)
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 25, 2023
…ver (celestiaorg#2554) When shard recovered in dagstore, it was read from in-memory mount, that could have been read 0 times and had no in-memory buffer. (cherry picked from commit 32834eb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shard recovered in dagstore, it was read from in-memory mount, that could have been read 0 times and had no in-memory buffer.