fix(header): Only bridge node should panic on data root mismatch in e… #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt header validation
renaynay
requested review from
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Wondertan
reviewed
Aug 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #2558 +/- ##
==========================================
+ Coverage 51.08% 51.15% +0.07%
==========================================
Files 158 158
Lines 10403 10398 -5
==========================================
+ Hits 5314 5319 +5
+ Misses 4626 4616 -10
Partials 463 463
|
Wondertan
approved these changes
Aug 10, 2023
vgonkivs
approved these changes
Aug 11, 2023
renaynay
added a commit
to renaynay/celestia-node
that referenced
this pull request
Aug 23, 2023
celestiaorg#2558) This PR fixes a DoS first discovered by @Wondertan and then secondarily by @vgonkivs 🤠 Only bridge nodes should panic on receiving a header where the computed data root does not match the DataHash in the RawHeader on ExtendedHeader validation. Resolves celestiaorg#2555
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
celestiaorg#2558) This PR fixes a DoS first discovered by @Wondertan and then secondarily by @vgonkivs 🤠 Only bridge nodes should panic on receiving a header where the computed data root does not match the DataHash in the RawHeader on ExtendedHeader validation. Resolves celestiaorg#2555 (cherry picked from commit 87e9500)
walldiss
pushed a commit
that referenced
this pull request
Sep 22, 2023
#2558) This PR fixes a DoS first discovered by @Wondertan and then secondarily by @vgonkivs 🤠 Only bridge nodes should panic on receiving a header where the computed data root does not match the DataHash in the RawHeader on ExtendedHeader validation. Resolves #2555 (cherry picked from commit 87e9500)
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
celestiaorg#2558) This PR fixes a DoS first discovered by @Wondertan and then secondarily by @vgonkivs 🤠 Only bridge nodes should panic on receiving a header where the computed data root does not match the DataHash in the RawHeader on ExtendedHeader validation. Resolves celestiaorg#2555 (cherry picked from commit 87e9500)
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 25, 2023
celestiaorg#2558) This PR fixes a DoS first discovered by @Wondertan and then secondarily by @vgonkivs 🤠 Only bridge nodes should panic on receiving a header where the computed data root does not match the DataHash in the RawHeader on ExtendedHeader validation. Resolves celestiaorg#2555 (cherry picked from commit 87e9500)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a DoS first discovered by @Wondertan and then secondarily by @vgonkivs 🤠
Only bridge nodes should panic on receiving a header where the computed data root does not match the DataHash in the RawHeader on ExtendedHeader validation.
Resolves #2555