feat(share/p2p/discovery): Warning for discovery loop if haven't found wanted peers in 5 minutes

[nodersteam]

refactor: Enhance peer discovery loop with connectivity warning

This commit refactors the discoveryLoop function in the Discovery struct
to include a connectivity warning timer. The timer is set to trigger every
5 minutes and checks if the number of discovered peers has not reached the
desired limit. If the limit is not met, a warning message is logged to
indicate potentially degraded connectivity.

Changes:

• Added a warning timer to the discoveryLoop function.
• The timer checks if the number of discovered peers is below the desired limit.
• If the condition is met, a warning message is logged.

This enhancement improves the monitoring and reporting of connectivity issues
during the peer discovery process.

Closes #2474

[codecov-commenter]

Codecov Report

Merging #2573 (260d273) into main (1205437) will decrease coverage by 0.17%.
The diff coverage is 43.75%.

@@            Coverage Diff             @@
##             main    #2573      +/-   ##
==========================================
- Coverage   51.33%   51.16%   -0.17%     
==========================================
  Files         158      158              
  Lines       10512    10520       +8     
==========================================
- Hits         5396     5383      -13     
- Misses       4645     4662      +17     
- Partials      471      475       +4     

Files Changed	Coverage Δ
share/p2p/discovery/discovery.go	72.45% <43.75%> (-2.99%)	⬇️

... and 4 files with indirect coverage changes

[nodersteam]

@walldiss

Good afternoon
What is the timing of the review?
Or did we do PR against the rules?

[walldiss]

Github duplicated my review, but then removed one of the copies. I've hided one, but it is still relevant. Please check it out in #2573 (review). Comments also visible from changes preview page.
Sorry for inconvenience.

[nodersteam]

log.Warnf("Discovery loop is running but can't find enough peers. Found: %d, Required: %d", d.metrics.discoveryAmountOfPeers, requiredAmountOfPeers)

We can also add to the output how many peers are connected

[nodersteam]

Something like this

[walldiss]

Need to fix some nits with comments and it is good.

log.Warnf("Discovery loop is running but can't find enough peers. Found: %d, Required: %d", d.metrics.discoveryAmountOfPeers, requiredAmountOfPeers)
We can also add to the output how many peers are connected

Up to you, but if you go with this, please use d.set.Size() and d.set.Limit() values instead of what you mentioned in example

[walldiss]

I know it feels exhausting, but we almost there! 🚀 Last nit:

[walldiss]

Last nit

[nodersteam]

I know it feels exhausting, but we almost there! 🚀 Last nit:

In fact, I would like to express my deep gratitude to you for all the comments and interactions with us here. For the first time we decided to make a contribution through interaction with the project code, and for us this is a great experience. Partly because of this, we can show that I am a little slow in understanding. It is important for us to understand exactly how interaction with development teams takes place in such large projects. Thank you very much for this, the next PR will be of better quality.

[nodersteam]

Now it's look like this

[walldiss]

LGTM! Thank you for contribution!

[Wondertan]

@nodersteam, lint is failing

[nodersteam]

@nodersteam, lint is failing

Thank you, I found the cause, I'm already fixing it

[nodersteam]

@Wondertan I see that Lint is falling again, I will fix everything tomorrow and make a correct commit. I'm sorry for this