feat(nodebuilder/state): Provide stubbed state module if a core endpoint not provided #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt is not provided
renaynay
added
area:node
renaynay
requested review from
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
renaynay
commented
Aug 17, 2023
renaynay
commented
Aug 17, 2023
Wondertan
reviewed
Aug 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #2577 +/- ##
==========================================
- Coverage 51.23% 50.99% -0.24%
==========================================
Files 158 158
Lines 10409 10444 +35
==========================================
- Hits 5333 5326 -7
- Misses 4613 4653 +40
- Partials 463 465 +2
|
Wondertan
previously approved these changes
Aug 18, 2023
distractedm1nd
previously approved these changes
Aug 21, 2023
renaynay
dismissed stale reviews from distractedm1nd and Wondertan
via
2d64795
distractedm1nd
approved these changes
Aug 21, 2023
Wondertan
approved these changes
Aug 21, 2023
walldiss
approved these changes
Aug 21, 2023
renaynay
added a commit
to renaynay/celestia-node
that referenced
this pull request
Aug 23, 2023
…int not provided (celestiaorg#2577) This is a pre-requisite for celestiaorg#2511 It makes a check in CoreAccessor constructor to see if a core endpoint was provided, and returns nil CoreAccessor if not. A stubbed state module will then be provided if no core endpoint was provided so that errors are more readable. Previously, node start logic relied on the fact that the grpc Dial inside CoreAccessor.Start was non-blocking so it could silently fail under the hood and any calls made on state Module would return errors from the inability to reach the address that is the default for the core config (which was confusing).
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
…int not provided (celestiaorg#2577) This is a pre-requisite for celestiaorg#2511 It makes a check in CoreAccessor constructor to see if a core endpoint was provided, and returns nil CoreAccessor if not. A stubbed state module will then be provided if no core endpoint was provided so that errors are more readable. Previously, node start logic relied on the fact that the grpc Dial inside CoreAccessor.Start was non-blocking so it could silently fail under the hood and any calls made on state Module would return errors from the inability to reach the address that is the default for the core config (which was confusing). (cherry picked from commit 13e9b1f)
walldiss
pushed a commit
that referenced
this pull request
Sep 22, 2023
…int not provided (#2577) This is a pre-requisite for #2511 It makes a check in CoreAccessor constructor to see if a core endpoint was provided, and returns nil CoreAccessor if not. A stubbed state module will then be provided if no core endpoint was provided so that errors are more readable. Previously, node start logic relied on the fact that the grpc Dial inside CoreAccessor.Start was non-blocking so it could silently fail under the hood and any calls made on state Module would return errors from the inability to reach the address that is the default for the core config (which was confusing). (cherry picked from commit 13e9b1f)
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
…int not provided (celestiaorg#2577) This is a pre-requisite for celestiaorg#2511 It makes a check in CoreAccessor constructor to see if a core endpoint was provided, and returns nil CoreAccessor if not. A stubbed state module will then be provided if no core endpoint was provided so that errors are more readable. Previously, node start logic relied on the fact that the grpc Dial inside CoreAccessor.Start was non-blocking so it could silently fail under the hood and any calls made on state Module would return errors from the inability to reach the address that is the default for the core config (which was confusing). (cherry picked from commit 13e9b1f)
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 25, 2023
…int not provided (celestiaorg#2577) This is a pre-requisite for celestiaorg#2511 It makes a check in CoreAccessor constructor to see if a core endpoint was provided, and returns nil CoreAccessor if not. A stubbed state module will then be provided if no core endpoint was provided so that errors are more readable. Previously, node start logic relied on the fact that the grpc Dial inside CoreAccessor.Start was non-blocking so it could silently fail under the hood and any calls made on state Module would return errors from the inability to reach the address that is the default for the core config (which was confusing). (cherry picked from commit 13e9b1f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-requisite for #2511
It makes a check in CoreAccessor constructor to see if a core endpoint was provided, and returns nil CoreAccessor if not. A stubbed state module will then be provided if no core endpoint was provided so that errors are more readable.
Previously, node start logic relied on the fact that the grpc Dial inside CoreAccessor.Start was non-blocking so it could silently fail under the hood and any calls made on state Module would return errors from the inability to reach the address that is the default for the core config (which was confusing).