nodebuilder/core: Set default ports for RPC and GRPC #2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
requested review from
Wondertan,
vgonkivs,
distractedm1nd and
walldiss
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2596 +/- ##
==========================================
+ Coverage 51.03% 51.19% +0.15%
==========================================
Files 157 157
Lines 10437 10439 +2
==========================================
+ Hits 5327 5344 +17
+ Misses 4642 4627 -15
Partials 468 468 |
renaynay
force-pushed
the
swamp-no-verify-coreconf
branch
from
b81a3f6
to
07453b9
Compare
renaynay
changed the title
Wondertan
approved these changes
Aug 22, 2023
vgonkivs
approved these changes
Aug 23, 2023
renaynay
added a commit
that referenced
this pull request
Aug 23, 2023
Now that we short-circuit on the IP address being empty, it's fine to set defaults for RPC and GRPC ports This fixes swamp tests as well
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
Now that we short-circuit on the IP address being empty, it's fine to set defaults for RPC and GRPC ports This fixes swamp tests as well (cherry picked from commit b6efbc9)
walldiss
pushed a commit
that referenced
this pull request
Sep 22, 2023
Now that we short-circuit on the IP address being empty, it's fine to set defaults for RPC and GRPC ports This fixes swamp tests as well (cherry picked from commit b6efbc9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we short-circuit on the IP address being empty, it's fine to set defaults for RPC and GRPC ports
This fixes swamp tests as well