feat(cmd/node): add logs cmd to dynamically change the log level #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
renaynay,
Wondertan,
distractedm1nd and
walldiss
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2601 +/- ##
==========================================
- Coverage 51.26% 51.25% -0.02%
==========================================
Files 157 158 +1
Lines 10490 10512 +22
==========================================
+ Hits 5378 5388 +10
- Misses 4637 4652 +15
+ Partials 475 472 -3
|
distractedm1nd
approved these changes
Aug 23, 2023
walldiss
approved these changes
Aug 23, 2023
renaynay
approved these changes
Aug 23, 2023
renaynay
approved these changes
Aug 23, 2023
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
…estiaorg#2601) ## Overview Added cmds that allow to change log level during runtime ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords (cherry picked from commit bbe970f)
walldiss
pushed a commit
that referenced
this pull request
Sep 22, 2023
## Overview Added cmds that allow to change log level during runtime ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [ ] New and updated code has appropriate documentation - [ ] New and updated code has new and/or updated testing - [ ] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [ ] Linked issues closed with keywords (cherry picked from commit bbe970f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added cmds that allow to change log level during runtime
Checklist