fix: fixing panic on GetShare with out of bounds indexes #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
added
area:shares
distractedm1nd
requested review from
renaynay,
Wondertan,
vgonkivs and
walldiss
as code owners
renaynay
previously approved these changes
Aug 24, 2023
Wondertan
previously approved these changes
Aug 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #2605 +/- ##
==========================================
+ Coverage 51.05% 51.22% +0.16%
==========================================
Files 158 158
Lines 10551 10564 +13
==========================================
+ Hits 5387 5411 +24
+ Misses 4690 4679 -11
Partials 474 474
|
renaynay
previously approved these changes
Aug 24, 2023
|
linter |
distractedm1nd
dismissed stale reviews from renaynay and Wondertan
via
abc8c70
vgonkivs
approved these changes
Aug 29, 2023
renaynay
approved these changes
Aug 29, 2023
walldiss
pushed a commit
that referenced
this pull request
Sep 22, 2023
GetShare would panic on RPC calls if the passed indicies were out of bounds. (cherry picked from commit 8deffba)
walldiss
pushed a commit
that referenced
this pull request
Sep 25, 2023
GetShare would panic on RPC calls if the passed indicies were out of bounds. (cherry picked from commit 8deffba)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetShare would panic on RPC calls if the passed indicies were out of bounds.