chore: bump go-header and go-fraud #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2619 +/- ##
==========================================
+ Coverage 51.16% 51.23% +0.06%
==========================================
Files 158 158
Lines 10522 10517 -5
==========================================
+ Hits 5384 5388 +4
+ Misses 4664 4658 -6
+ Partials 474 471 -3
|
renaynay
reviewed
Aug 29, 2023
vgonkivs
requested changes
Aug 29, 2023
renaynay
approved these changes
Aug 30, 2023
vgonkivs
approved these changes
Aug 30, 2023
walldiss
pushed a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 22, 2023
This PR bumps go-header and go-fraud which are both breaking - lots of changes here so please review carefully. Note that this also contains re-introduction of VerifyCommitLightTrusting which caused us issues in `mocha` due to rapid voting power changes. At the moment, there are no test utilities to test that specific case, so we need to wait to roll it out to `mocha`. Related: celestiaorg/celestia-app#2382 --------- Co-authored-by: rene <41963722+renaynay@users.noreply.github.com> (cherry picked from commit 9d663cf)
walldiss
pushed a commit
that referenced
this pull request
Sep 22, 2023
This PR bumps go-header and go-fraud which are both breaking - lots of changes here so please review carefully. Note that this also contains re-introduction of VerifyCommitLightTrusting which caused us issues in `mocha` due to rapid voting power changes. At the moment, there are no test utilities to test that specific case, so we need to wait to roll it out to `mocha`. Related: celestiaorg/celestia-app#2382 --------- Co-authored-by: rene <41963722+renaynay@users.noreply.github.com> (cherry picked from commit 9d663cf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps go-header and go-fraud which are both breaking - lots of changes here so please review carefully.
Note that this also contains re-introduction of VerifyCommitLightTrusting which caused us issues in
mochadue to rapid voting power changes. At the moment, there are no test utilities to test that specific case, so we need to wait to roll it out tomocha.Related: celestiaorg/celestia-app#2382