-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eds/store): remove corrupted blocks from store #2625
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2625 +/- ##
==========================================
- Coverage 51.15% 51.05% -0.11%
==========================================
Files 158 158
Lines 10558 10638 +80
==========================================
+ Hits 5401 5431 +30
- Misses 4681 4732 +51
+ Partials 476 475 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some minor comments from perspective of a new set of eyes on the project. I think logging shard failures and removals would be super useful for both a node runner, but also as it feels like this doesn't solve the issue, but is a step towards more work in this area.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some code structuring suggestions and one small issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint and pls check swamp tests locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small one left
5aef478
to
cc6a659
Compare
Related to #2335
If an OpShardFail is found or corruption is detected from GetSharesByNamespace, the shard is removed