feat(share/store/cache): Split accessor cache into recent and blockstore #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update metrics - fix tests
# Conflicts: # share/eds/blockstore.go # share/eds/store.go
- fix merge conflicts
# Conflicts: # share/eds/metrics.go
# Conflicts: # share/eds/accessor_cache.go # share/eds/metrics.go # share/eds/store.go
walldiss
force-pushed
the
split-accessor-cache-for-real
branch
from
8b657c1
to
04d7c6c
Compare
# Conflicts: # share/eds/blockstore.go # share/eds/cache/accessor_cache.go # share/eds/cache/accessor_cache_test.go # share/eds/cache/cache.go # share/eds/cache/metrics.go # share/eds/store.go # share/eds/store_test.go # share/eds/utils.go # share/p2p/shrexeds/server.go
walldiss
force-pushed
the
split-accessor-cache-for-real
branch
from
a6fd8bf
to
0f66f2d
Compare
walldiss
force-pushed
the
split-accessor-cache-for-real
branch
from
0f66f2d
to
95e1fa8
Compare
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Wondertan
reviewed
Sep 18, 2023
renaynay
reviewed
Sep 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #2656 +/- ##
==========================================
- Coverage 51.55% 51.48% -0.08%
==========================================
Files 162 163 +1
Lines 10755 10784 +29
==========================================
+ Hits 5545 5552 +7
- Misses 4729 4751 +22
Partials 481 481
|
distractedm1nd
previously approved these changes
Sep 18, 2023
|
Should we robusta test this before we merge into main? |
|
I would rather run tests once all cache relateed PRs are merged. There are 2 more left, but they are relatedly simple |
|
@walldiss then we should cut an RC once you get the next 2 up |
Wondertan
approved these changes
Sep 18, 2023
renaynay
approved these changes
Sep 18, 2023
vgonkivs
pushed a commit
to vgonkivs/celestia-node
that referenced
this pull request
Oct 5, 2023
…ore (celestiaorg#2656) Adds MultiCache. Replaces eds store cache with multicache containing 2 separate caches: - recently added edses (10 accessors, added on put only) - edses requested by ipld (128 accessors, added on request to blockstore from bitswap server)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MultiCache. Replaces eds store cache with multicache containing 2 separate caches: