refactor(nodebuilder/header): get rid of InitStore

[renaynay]

Not needed anymore

[codecov-commenter]

Codecov Report

Merging #2678 (a37e634) into main (d803cf8) will decrease coverage by 0.12%.
Report is 3 commits behind head on main.
The diff coverage is 23.07%.

@@            Coverage Diff             @@
##             main    #2678      +/-   ##
==========================================
- Coverage   51.48%   51.36%   -0.12%     
==========================================
  Files         159      159              
  Lines       10677    10676       -1     
==========================================
- Hits         5497     5484      -13     
- Misses       4707     4715       +8     
- Partials      473      477       +4     

Files Changed	Coverage Δ
nodebuilder/header/module.go	52.63% <ø> (+4.10%)	⬆️
nodebuilder/header/constructors.go	50.00% <16.66%> (-8.00%)	⬇️
nodebuilder/testing.go	100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

[distractedm1nd]

utACK. Have you tested locally?

[Wondertan]

My intuition says me like there might be something subtle we miss by doing so. I clearly remember we had to do it, but don't remember why.

Does it works properly on non and initialised node node? Also, the test change is suspicious

[renaynay]

@Wondertan Yes works for inited and non-inited nodes.

[Wondertan]

It seems like there is no blocker anymore for this simplification.
Thanks for this @renaynay!