feat(share/eds/store): expose eds store params #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update metrics - fix tests
# Conflicts: # share/eds/blockstore.go # share/eds/store.go
- fix merge conflicts
# Conflicts: # share/eds/metrics.go
# Conflicts: # share/eds/accessor_cache.go # share/eds/metrics.go # share/eds/store.go
# Conflicts: # share/eds/store.go
# Conflicts: # share/eds/blockstore.go # share/eds/cache/accessor_cache.go # share/eds/cache/accessor_cache_test.go # share/eds/cache/cache.go # share/eds/cache/metrics.go # share/eds/store.go # share/eds/store_test.go # share/eds/utils.go # share/p2p/shrexeds/server.go
# Conflicts: # share/eds/blockstore.go # share/eds/cache/accessor_cache.go # share/eds/cache/accessor_cache_test.go # share/eds/cache/cache.go # share/eds/cache/multicache.go # share/eds/store.go # share/eds/store_test.go # share/eds/utils.go
# Conflicts: # share/eds/blockstore.go # share/eds/store.go
Codecov Report
@@ Coverage Diff @@
## main #2724 +/- ##
==========================================
+ Coverage 51.60% 51.63% +0.03%
==========================================
Files 163 164 +1
Lines 10859 10887 +28
==========================================
+ Hits 5604 5622 +18
- Misses 4769 4775 +6
- Partials 486 490 +4
|
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
Wondertan
reviewed
Sep 21, 2023
distractedm1nd
previously approved these changes
Sep 21, 2023
walldiss
force-pushed
the
expose-eds-store-config
branch
from
409fba3
to
2ca14d7
Compare
Wondertan
approved these changes
Sep 21, 2023
distractedm1nd
approved these changes
Sep 21, 2023
vgonkivs
pushed a commit
to vgonkivs/celestia-node
that referenced
this pull request
Oct 5, 2023
Adds exported params to allow control of eds store configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds exported params to allow control of eds store configuration