refactoring(full/availability): removing TeeGetter, storing via SharesAvailable #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distractedm1nd
requested review from
Wondertan,
vgonkivs and
walldiss
as code owners
Wondertan
previously approved these changes
Sep 18, 2023
walldiss
reviewed
Sep 19, 2023
distractedm1nd
force-pushed
the
remove-tee-getter
branch
2 times, most recently
from
e0d73b6
to
84fe424
Compare
Codecov Report
@@ Coverage Diff @@
## main #2726 +/- ##
==========================================
+ Coverage 51.49% 51.83% +0.33%
==========================================
Files 163 162 -1
Lines 10784 10758 -26
==========================================
+ Hits 5553 5576 +23
+ Misses 4750 4698 -52
- Partials 481 484 +3
|
Wondertan
previously approved these changes
Sep 20, 2023
walldiss
previously approved these changes
Sep 21, 2023
renaynay
previously approved these changes
Sep 21, 2023
distractedm1nd
dismissed stale reviews from renaynay, walldiss, and Wondertan
via
6ef869d
distractedm1nd
force-pushed
the
remove-tee-getter
branch
from
84fe424
to
6ef869d
Compare
walldiss
previously approved these changes
Sep 21, 2023
distractedm1nd
dismissed stale reviews from renaynay and walldiss
via
ec0d035
walldiss
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We never needed TeeGetter, full availability already has access to the store. This is also needed for pruning