Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(share/discovery): decrease default Advertisement interval #2758

Merged
merged 1 commit into from
Sep 25, 2023
Merged

refactor(share/discovery): decrease default Advertisement interval #2758

merged 1 commit into from
Sep 25, 2023

Conversation

walldiss
Copy link
Member

Resolves #2704

@walldiss walldiss added area:p2p kind:refactor Attached to refactoring PRs labels Sep 25, 2023
@walldiss walldiss self-assigned this Sep 25, 2023
@walldiss walldiss enabled auto-merge (squash) September 25, 2023 12:45
@codecov-commenter
Copy link

Codecov Report

Merging #2758 (3fa6f3f) into main (3426751) will increase coverage by 0.12%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2758      +/-   ##
==========================================
+ Coverage   51.80%   51.92%   +0.12%     
==========================================
  Files         163      163              
  Lines       10856    10855       -1     
==========================================
+ Hits         5624     5637      +13     
+ Misses       4737     4726      -11     
+ Partials      495      492       -3
Files Changed Coverage Δ
share/p2p/discovery/options.go 59.09% <100.00%> (-1.78%) ⬇️

... and 3 files with indirect coverage changes

@walldiss walldiss merged commit 8602d6e into celestiaorg:main Sep 25, 2023
12 of 14 checks passed
vgonkivs pushed a commit to vgonkivs/celestia-node that referenced this pull request Oct 5, 2023
@walldiss @vgonkivs
refactor(share/discovery): decrease default Advertisement interval (c…
0f11e83 
…elestiaorg#2758)

Resolves celestiaorg#2704
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renaynay renaynay renaynay approved these changes

@Wondertan Wondertan Wondertan approved these changes

@distractedm1nd distractedm1nd distractedm1nd approved these changes

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

Assignees

@walldiss walldiss

Labels
area:p2p kind:refactor Attached to refactoring PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

share/discovery: decrease default Advertisement interval
5 participants
@walldiss @codecov-commenter @distractedm1nd @Wondertan @renaynay