Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(share/eds): fix races in cache tests #2834

Merged
merged 4 commits into from
Oct 12, 2023
Merged

fix(share/eds): fix races in cache tests #2834

merged 4 commits into from
Oct 12, 2023

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Oct 10, 2023 •
edited
Loading

Fixes races in eds cache tests:

  • read / write isClosed flag in Cache mock
  • write / write for error object from 2 goroutines
  • read / write of cache object inside edsStore on cache swaps in tests.

Resolves #2833

@walldiss walldiss self-assigned this Oct 10, 2023
@walldiss walldiss added kind:fix Attached to bug-fixing PRs kind:testing Related to unit tests labels Oct 10, 2023
ramin
ramin previously approved these changes Oct 10, 2023
View reviewed changes
@walldiss walldiss marked this pull request as ready for review October 10, 2023 13:39
@walldiss walldiss requested a review from ramin October 10, 2023 13:40
@walldiss walldiss merged commit 7491d53 into celestiaorg:main Oct 12, 2023
14 of 16 checks passed
@faddat faddat mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wondertan Wondertan Wondertan approved these changes

@ramin ramin ramin approved these changes

@renaynay renaynay Awaiting requested review from renaynay renaynay is a code owner

@vgonkivs vgonkivs Awaiting requested review from vgonkivs vgonkivs is a code owner

@distractedm1nd distractedm1nd Awaiting requested review from distractedm1nd

Assignees

@walldiss walldiss

@Wondertan Wondertan

Labels
kind:fix Attached to bug-fixing PRs kind:testing Related to unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

share/eds: TestBlockstoreCache is racy
3 participants
@walldiss @ramin @Wondertan